Discover RDS deploys version out of sync with deployment updater

[GavinFrazar]

I had an ECS cluster deployed via the integration already, but I had manually scaled the service tasks to 0.

In the background, the AWS OIDC integration updater checks if it should update ECS task definitions to a newer version of Teleport. It checks for a cluster maintenance window every 30 minutes, and if it's in the window then it updates ECS deployments.

In this case, this morning the auto-updater created a new task revision for v16.3.0 and updated my ECS cluster to use the new revision. The prior revision used v16.2.2.

Today, I went through the discover flow again, and when I clicked "Deploy Teleport Service" it updated my ECS cluster service to run 2 tasks again, but it also created a new task definition that again used v16.2.2.

So the ECS task definition revisions look like this:
revision 1: teleport v16.2.2 (from when I created it the first time)
revision 2: teleport v16.3.0 (auto-updater created this morning)
revision 3: teleport v16.2.2 (redeployed teleport service this afternoon)

I found it quite surprising that my ECS service was downgraded.

We need to make sure the service deployment version matches what we use for the auto-updater.

Bug details:

• Teleport version: 16.3.0

[GavinFrazar]

cc @marcoandredinis

[marcoandredinis]

The version check has slightly different conditions, but they seem to resolve to the same version 🤔

teleport/lib/service/awsoidc.go

Line 196 in ca05dd1

stableVersion, err := updater.UpgradeChannel.GetVersion(ctx)

teleport/lib/web/integrations_awsoidc.go

Line 152 in b453967

cloudStableVersion, err := h.cfg.AutomaticUpgradesChannels.DefaultVersion(ctx)

Was this a self-hosted tenant? Maybe that's why

[GavinFrazar]

The version check has slightly different conditions, but they seem to resolve to the same version 🤔

teleport/lib/service/awsoidc.go

Line 196 in ca05dd1

stableVersion, err := updater.UpgradeChannel.GetVersion(ctx)

teleport/lib/web/integrations_awsoidc.go

Line 152 in b453967

cloudStableVersion, err := h.cfg.AutomaticUpgradesChannels.DefaultVersion(ctx)

Was this a self-hosted tenant? Maybe that's why

it was a cloud staging tenant