Improve the method name_to_position

[guilhermesilveira]

It could use a simple cached hash map (dictionary) for quick lookup, no comparisons done.

[NovusEdge]

I would like to take this issue up if no one's assigned

[guilhermesilveira]

Sure, go ahead! Let me know if you need something

[NovusEdge]

@guilhermesilveira
Could you please tell me where the method is (which file) and how would you like it to be improved?

[guilhermesilveira]

@NovusEdge sure. Here is the current code:
https://github.com/guilhermesilveira/generativemagic/blob/main/generativemagic/spelling.py#L20

There is a private method responsible for taking the list of values [0,...,10,JACK,QUEEN, KING] and list of suits, and the name of a card [1 of clubs etc]. So it does the math to return the position of the card in a simple deck.

I believe the easiest way is to remove all the private methods here and then on the english (and portuguese) initiation method you can iterate over the numbers 1 to 52, invoke self.card_name(k). The result of that call can be cached in a self._cached_names. So the method name_to_position becomes a simple look up in the self._cached_names dictionary

Let me knoiw if you need something else