Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closure-compiler build requires extra annotations to scan classes #9974

Open
niloc132 opened this issue Jul 3, 2024 · 1 comment
Open

closure-compiler build requires extra annotations to scan classes #9974

niloc132 opened this issue Jul 3, 2024 · 1 comment

Comments

@niloc132
Copy link
Contributor

niloc132 commented Jul 3, 2024

Our most recent sourcemap update (see gwtproject/tools@87db1e0) also fixed a TODO that the closure-compiler team no longer seems to consider a useful change. This looks to be as simple as dropping the first patch when rebasing to the next version.

In the meantime, this is just a marker for reverting extra dependencies for the RequestFactoryJarExtractor build task.

@vegegoku
Copy link
Contributor

vegegoku commented Jul 4, 2024

GWT builds after updating the source maps jars have been showing some warnings while executing request factory tasks, this due to the fact that RequestFactoryExtractor is trying to recursively process classes from the build path and the recent sourcemaps classes in the new dependencies have some references to some google-auto annotations like @AutoValue (specifically the OriginalMapping class) but those are not present in the RequestFactoryExtractor task build path so they could not be loaded using the class-loader resulting in the warning we see in the build logs.

We can fix those warnings by either removing those references from the sourcemaps jars or by adding the missing classes to the build path, for example adding error_prone jars to the build path since it include those classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants