Availability: Weekday afternoons (2pm–5pm Pacific)

ETA: 31 January

@DrAcula27

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
2. Blockers: "Difficulties or errors encountered."
3. Availability: "How much time will you have this week to work on this issue?"
4. ETA: "When do you expect this issue to be completed?"
5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

_{You are receiving this comment because your last comment was before Monday, January 27, 2025 at 11:04 PM PST.}

Progress: see checked boxes in issue.
Blockers: see question in next comment.
Availability: weekdays from 2pm to 6pm pacific time
ETA: 7 Feb, 2025

Questions

1. Should I also change every instance of Github or github in assets/js/wins.js where GitHub is mentioned in text (i.e., not as a variable name)?
   • Currently, I have Github or github changed to GitHub on lines 12, 13, 28, and 509 (the requested change)
2. If I should keep the change from Github to GitHub on lines 12 and 13:
   • 12 const github_url = "Github URL (optional)"
   • 13 const github_permission = "Could we use your Github profile picture next to your story?"
   • then that will affect 2 more files:
     • _data/external/_wins-data.json
     • google-apps-scripts/wins-form-responses/Code.js
   • and I will need to change every instance of Github to GitHub in these two files.
   • otherwise, no other files need to change.
3. If I do make these changes, and then update the other files, I don't think any testing will need to be done.

Expected changes

• I don't expect to see any visual changes to the website, UNLESS I get the go-ahead to change the instances of Github to GitHub on lines 12 and 13 of assets/js/wins.js and the listed affected files in my comment above.
  • If I do, I expect the second page of the Share your wins with us! Google form to change in these two lines:
    • Github URL (optional) → GitHub URL (optional)
    • Could we use your Github profile picture next to your story? ⇾ Could we use your GitHub profile picture next to your story?

Hi @DrAcula27,

1. You do not need to change the other instances of Github in this file, only the one within the specified function. As you noted, changing the other instances would also affect other files, so they will be done in a separate issue. Hopefully this addresses 2 and 3 too.
   Also regarding your expected changes, you're correct there should be no visual changes on the website from changing the specified instance of Github. However, the changes do show up in the HTML for the Wins page as alt text for the github-icon class, so you may want to write a test procedure for reviewers to follow so they can verify the changes there.
   Hope this helps, and sorry for the wait!

Thank you @daras-cu for the reply!

• I will only change the instance of Github on line 509 and write out that test in a following comment.
• ETA: still 7 Feb 2025, thanks for answering in time to keep me on schedule 😄

Expected Changes - Revised

• Since I only need to change one instance of the word Github to GitHub in assets/js/wins.js (on line 509), there will be no immediate visual changes to the website.
• However, the alt text in the HTML for the Wins page will be updated from Github profile for <name> to GitHub profile for <name>

Testing Procedure for Expected Changes

1. Follow the HfLA procedure for reviewing a PR until you get to the step where you have the live version of the site (https://www.hackforla.org) open next to your local version (running in a Docker container).
2. In both instances of the website, click on the Wins button in the navbar.
3. Open your browser's developer tools:
   • Firefox: right click > Inspect > ensure the Inspector tab is active
   • Chrome: right click > Inspect > ensure the Elements tab is active
4. CTRL + Shift + C to activate the option to Select an element in the page to inspect it
5. Click on the GitHub icon in the top-right corner of a few of the contributors' cards (or all of them if you feel like it!) to automatically scroll to that element in the Inspector (Firefox) or Elements (Chrome) tab of your browser's developer tools.
6. Once that element is highlighted, check that the alt attribute of the img element housing the GitHub icon says GitHub profile for <name>, NOT Github profile for <name>.
7. Continue with the rest of the review PR steps to finish, and thank you!