allow client to be reused when creating connections to other servers #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
lukedegruchy
reviewed
Aug 8, 2024
hapi-fhir-base/src/main/java/ca/uhn/fhir/rest/param/HttpClientRequestParameters.java
Show resolved
Hide resolved
lukedegruchy
reviewed
Aug 8, 2024
hapi-fhir-base/src/main/java/ca/uhn/fhir/rest/param/HttpClientRequestParameters.java
Show resolved
Hide resolved
lukedegruchy
reviewed
Aug 8, 2024
hapi-fhir-client/src/main/java/ca/uhn/fhir/rest/client/method/HttpPatchClientInvocation.java
Show resolved
Hide resolved
lukedegruchy
approved these changes
Aug 8, 2024
added 10 commits
August 9, 2024 12:01
tadgh
requested changes
Aug 19, 2024
added 3 commits
August 20, 2024 10:21
tadgh
reviewed
Aug 20, 2024
...fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
Show resolved
Hide resolved
| myServer.getInterceptorService().unregisterInterceptor(interceptor); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
There is one more missing test here: Test that a created client correctly re-uses its settings through multiple invocations of search/get/create (which was the original bug, right?)
There was a problem hiding this comment.
original bug was in gateway. but i can turn this into a set of tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6180