Skip to content

Commit 4368cad

Browse files
authored
Merge pull request buildkite-plugins#128 from buildkite-plugins/bump-to-1MB
Bump annotation limit to 1MB
2 parents c0ea27d + ba70d37 commit 4368cad

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

hooks/command

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
set -euo pipefail
44

55
PLUGIN_DIR="$(cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd)/.."
6-
MAX_SIZE=100 # in KB
6+
MAX_SIZE=1024 # in KB
77

88
echo "--- :junit: Download the junits"
99

tests/command.bats

+3-3
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ load "$BATS_PATH/load.bash"
121121
assert_output --partial "BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS: unbound variable"
122122
}
123123

124-
@test "fails if the annotation is larger than " {
124+
@test "fails if the annotation is larger than 1MB" {
125125
export BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS="junits/*.xml"
126126

127127
artifacts_tmp="tests/tmp/$PWD/junit-artifacts"
@@ -131,8 +131,8 @@ load "$BATS_PATH/load.bash"
131131
"-d junit-annotate-plugin-artifacts-tmp.XXXXXXXXXX : mkdir -p $artifacts_tmp; echo $artifacts_tmp" \
132132
"-d junit-annotate-plugin-annotation-tmp.XXXXXXXXXX : mkdir -p $annotation_tmp; echo $annotation_tmp"
133133

134-
# 1kb over the 100k size limit of annotations
135-
stub du "-k /plugin/tests/tmp//plugin/junit-annotation/annotation.md : echo 101 /plugin/tests/tmp//plugin/junit-annotation/annotation.md"
134+
# 1KB over the 1MB size limit of annotations
135+
stub du "-k /plugin/tests/tmp//plugin/junit-annotation/annotation.md : echo 1025 /plugin/tests/tmp//plugin/junit-annotation/annotation.md"
136136

137137
stub buildkite-agent "artifact download junits/*.xml /plugin/tests/tmp//plugin/junit-artifacts : echo Downloaded artifacts"
138138

0 commit comments

Comments
 (0)