Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV -> XLSX conversion fails with an error #230

Open
niryariv opened this issue Jun 6, 2021 · 4 comments
Open

CSV -> XLSX conversion fails with an error #230

niryariv opened this issue Jun 6, 2021 · 4 comments
Assignees

Comments

@niryariv
Copy link

niryariv commented Jun 6, 2021

  1. Uploaded CSV file, views correctly here
  2. Attempting to upload to datastore via admin UI fails with a UnicodeEncodeError message:
    Screen Shot 2021-06-06 at 12 08 51
@OriHoch
Copy link
Contributor

OriHoch commented Jun 7, 2021

duplicate of #213 explanation in this comment: #213 (comment)

@OriHoch OriHoch assigned niryariv and unassigned OriHoch Jun 7, 2021
@niryariv
Copy link
Author

niryariv commented Jun 7, 2021

@OriHoch Since this happens when we do the conversion (users are instructed to avoid uploading XLS files) and it seems to break on specific characters like " (other files with Hebrew headers convert ok) is it possible to add some code that removes these characters from the header row before starting the XLSX conversion? How much work do you estimate?

@OriHoch
Copy link
Contributor

OriHoch commented Jun 7, 2021

I don't see how it is related to XLSX conversion, this is the bug as I understand it:

reproduction steps

  • upload a csv file which contains special characters (like quotes) in a field name
  • check resource view (example)
  • check datastore upload log (example)

expected

  • resource view page: shows green data api button and data dictionary displayed below the table
    image
    image
  • upload log shows status completed

actual

  • resource view page: no green data api button, data dictionary is not displayed below the table
    image
    image
  • upload log shows status failed
    image

@OriHoch
Copy link
Contributor

OriHoch commented Jun 7, 2021

I estimate 5-10 hours to fix the bug I described in previous comment

@OriHoch OriHoch removed their assignment Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants