Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should add committee membership data from the new knesset API #10

Open
OriHoch opened this issue Apr 23, 2017 · 1 comment
Open

should add committee membership data from the new knesset API #10

OriHoch opened this issue Apr 23, 2017 · 1 comment
Assignees

Comments

@OriHoch
Copy link
Contributor

OriHoch commented Apr 23, 2017

expected outcome

this is only a suggestion, feel free to implement it another way

from knesset_data.dataservice.persons import PersonPosition
for person_position in PersonPosition.get_all():
    peson_position.PersonID
    person_position.CommitteeID
    # all other fields..
    
    # mk = Member of Knesset
    # this method should return the standard member id, like:
    # 901 = איציק שמולי
    person_position.get_mk_id()
    
    # given person_position.CommitteeId
    # fetch and return a dataservice.committees.Committee object
    person_position.get_committee()

relevant documentation and details:

@OriHoch
Copy link
Contributor Author

OriHoch commented Apr 30, 2017

the basic data is there, but some follow-up is needed:

  • write automated tests
  • fix the is_current field boolean value
  • add the relationship to committees (possibly just document it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants