[Enhancement]: Support ml.g6e.xlarge for aws_sagemaker_notebook_instance instance_type

[nickt1512]

Description

Sagemaker just released g6e instance types (https://aws.amazon.com/about-aws/whats-new/2024/10/amazon-sagemaker-studio-notebooks-g6e-instance-types/). Could you please add this to the supported list of instance types?

Error: expected instance_type to be one of ["ml.t2.medium" "ml.t2.large" "ml.t2.xlarge" "ml.t2.2xlarge" "ml.t3.medium" "ml.t3.large" "ml.t3.xlarge" "ml.t3.2xlarge" "ml.m4.xlarge" "ml.m4.2xlarge" "ml.m4.4xlarge" "ml.m4.10xlarge" "ml.m4.16xlarge" "ml.m5.xlarge" "ml.m5.2xlarge" "ml.m5.4xlarge" "ml.m5.12xlarge" "ml.m5.24xlarge" "ml.m5d.large" "ml.m5d.xlarge" "ml.m5d.2xlarge" "ml.m5d.4xlarge" "ml.m5d.8xlarge" "ml.m5d.12xlarge" "ml.m5d.16xlarge" "ml.m5d.24xlarge" "ml.c4.xlarge" "ml.c4.2xlarge" "ml.c4.4xlarge" "ml.c4.8xlarge" "ml.c5.xlarge" "ml.c5.2xlarge" "ml.c5.4xlarge" "ml.c5.9xlarge" "ml.c5.18xlarge" "ml.c5d.xlarge" "ml.c5d.2xlarge" "ml.c5d.4xlarge" "ml.c5d.9xlarge" "ml.c5d.18xlarge" "ml.p2.xlarge" "ml.p2.8xlarge" "ml.p2.16xlarge" "ml.p3.2xlarge" "ml.p3.8xlarge" "ml.p3.16xlarge" "ml.p3dn.24xlarge" "ml.g4dn.xlarge" "ml.g4dn.2xlarge" "ml.g4dn.4xlarge" "ml.g4dn.8xlarge" "ml.g4dn.12xlarge" "ml.g4dn.16xlarge" "ml.r5.large" "ml.r5.xlarge" "ml.r5.2xlarge" "ml.r5.4xlarge" "ml.r5.8xlarge" "ml.r5.12xlarge" "ml.r5.16xlarge" "ml.r5.24xlarge" "ml.g5.xlarge" "ml.g5.2xlarge" "ml.g5.4xlarge" "ml.g5.8xlarge" "ml.g5.16xlarge" "ml.g5.12xlarge" "ml.g5.24xlarge" "ml.g5.48xlarge" "ml.inf1.xlarge" "ml.inf1.2xlarge" "ml.inf1.6xlarge" "ml.inf1.24xlarge" "ml.trn1.2xlarge" "ml.trn1.32xlarge" "ml.trn1n.32xlarge" "ml.inf2.xlarge" "ml.inf2.8xlarge" "ml.inf2.24xlarge" "ml.inf2.48xlarge" "ml.p4d.24xlarge" "ml.p4de.24xlarge" "ml.p5.48xlarge" "ml.m6i.large" "ml.m6i.xlarge" "ml.m6i.2xlarge" "ml.m6i.4xlarge" "ml.m6i.8xlarge" "ml.m6i.12xlarge" "ml.m6i.16xlarge" "ml.m6i.24xlarge" "ml.m6i.32xlarge" "ml.m7i.large" "ml.m7i.xlarge" "ml.m7i.2xlarge" "ml.m7i.4xlarge" "ml.m7i.8xlarge" "ml.m7i.12xlarge" "ml.m7i.16xlarge" "ml.m7i.24xlarge" "ml.m7i.48xlarge" "ml.c6i.large" "ml.c6i.xlarge" "ml.c6i.2xlarge" "ml.c6i.4xlarge" "ml.c6i.8xlarge" "ml.c6i.12xlarge" "ml.c6i.16xlarge" "ml.c6i.24xlarge" "ml.c6i.32xlarge" "ml.c7i.large" "ml.c7i.xlarge" "ml.c7i.2xlarge" "ml.c7i.4xlarge" "ml.c7i.8xlarge" "ml.c7i.12xlarge" "ml.c7i.16xlarge" "ml.c7i.24xlarge" "ml.c7i.48xlarge" "ml.r6i.large" "ml.r6i.xlarge" "ml.r6i.2xlarge" "ml.r6i.4xlarge" "ml.r6i.8xlarge" "ml.r6i.12xlarge" "ml.r6i.16xlarge" "ml.r6i.24xlarge" "ml.r6i.32xlarge" "ml.r7i.large" "ml.r7i.xlarge" "ml.r7i.2xlarge" "ml.r7i.4xlarge" "ml.r7i.8xlarge" "ml.r7i.12xlarge" "ml.r7i.16xlarge" "ml.r7i.24xlarge" "ml.r7i.48xlarge" "ml.m6id.large" "ml.m6id.xlarge" "ml.m6id.2xlarge" "ml.m6id.4xlarge" "ml.m6id.8xlarge" "ml.m6id.12xlarge" "ml.m6id.16xlarge" "ml.m6id.24xlarge" "ml.m6id.32xlarge" "ml.c6id.large" "ml.c6id.xlarge" "ml.c6id.2xlarge" "ml.c6id.4xlarge" "ml.c6id.8xlarge" "ml.c6id.12xlarge" "ml.c6id.16xlarge" "ml.c6id.24xlarge" "ml.c6id.32xlarge" "ml.r6id.large" "ml.r6id.xlarge" "ml.r6id.2xlarge" "ml.r6id.4xlarge" "ml.r6id.8xlarge" "ml.r6id.12xlarge" "ml.r6id.16xlarge" "ml.r6id.24xlarge" "ml.r6id.32xlarge" "ml.g6.xlarge" "ml.g6.2xlarge" "ml.g6.4xlarge" "ml.g6.8xlarge" "ml.g6.12xlarge" "ml.g6.16xlarge" "ml.g6.24xlarge" "ml.g6.48xlarge"], got ml.g6e.xlarge

Affected Resource(s) and/or Data Source(s)

aws_sagemaker_notebook_instance

Potential Terraform Configuration

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[stefanfreitag]

Good evening @nickt1512 👋 ,

thank you for raising this issue!
Could you please share the Terraform version you are currently using?

I think in the latest Terraform version 5.87.0 the new instance type is already supported - let me verify this!

Update:

• The support for G6e instance type for Sagemaker was added to the AWS Go SDK v2 release 1.166.0 in October 2024.
• The Terraform AWS provider upgraded to that SDK version around November 2024 (commit id: 6e80e47)
• The provider version 5.75.0 is the first version containing the support.

(Actually, the provider checks if your input is contained in the list of supported instance types, definded in the AWS SDK)

[nickt1512]

Thanks for the quick response @stefanfreitag . Currently, we're using Terraform 1.10.5 and hashicorp/aws ~> 5.87. From your post, it should be able to support that g6e instance. I will investigate more and let you know. Thanks!

[stefanfreitag]

Good morning @nickt1512 ,

thanks for providing the Terraform provider version. I had a closer look this morning and it feels I missed one point yesterday: the aws_sagemaker_notebook_instance uses a validation on the type Instance_Type and here the g6e is not available. It is present in other types like ProductionVariantInstanceType, i.e.

	ProductionVariantInstanceTypeMlG648xlarge    ProductionVariantInstanceType = "ml.g6.48xlarge"
	ProductionVariantInstanceTypeMlG6eXlarge     ProductionVariantInstanceType = "ml.g6e.xlarge"
	ProductionVariantInstanceTypeMlG6e2xlarge    ProductionVariantInstanceType = "ml.g6e.2xlarge"
	ProductionVariantInstanceTypeMlG6e4xlarge    ProductionVariantInstanceType = "ml.g6e.4xlarge"
	ProductionVariantInstanceTypeMlG6e8xlarge    ProductionVariantInstanceType = "ml.g6e.8xlarge"
	ProductionVariantInstanceTypeMlG6e12xlarge   ProductionVariantInstanceType = "ml.g6e.12xlarge"
	ProductionVariantInstanceTypeMlG6e16xlarge   ProductionVariantInstanceType = "ml.g6e.16xlarge"
	ProductionVariantInstanceTypeMlG6e24xlarge   ProductionVariantInstanceType = "ml.g6e.24xlarge"
	ProductionVariantInstanceTypeMlG6e48xlarge   ProductionVariantInstanceType = "ml.g6e.48xlarge"
	ProductionVariantInstanceTypeMlP4d24xlarge   ProductionVariantInstanceType = "ml.p4d.24xlarge"
	ProductionVariantInstanceTypeMlC7gLarge      ProductionVariantInstanceType = "ml.c7g.large"
	ProductionVariantInstanceTypeMlC7gXlarge     ProductionVariantInstanceType = "ml.c7g.xlarge"

This ProductionVariantInstanceType is part of the resource aws_sagemaker_endpoint_configuration.

I logged in to my AWS account and checked in Oregon region (based on the whats-new you linked) and checked if I could select the instance type manually via console:

It is not available in the selection list. Could you please check on your end?

Links

• CloudFormation docs on SageMaker Notebook Instance Type, also not listing the g6e
• CloudFormation docs on SageMaker Endpoint configuration, listing the g6e