Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TechDebt]: Document resource annotation formatting #41515

Open
jar-b opened this issue Feb 21, 2025 · 1 comment
Open

[TechDebt]: Document resource annotation formatting #41515

jar-b opened this issue Feb 21, 2025 · 1 comment
Labels
documentation Introduces or discusses updates to documentation. linter Pertains to changes to or issues with the various linters. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@jar-b
Copy link
Member

jar-b commented Feb 21, 2025

Description

All resources and data sources now utilize annotations to facilitate self-registration and configuration of generated code. We should document the expected format for all potential annotations so contributors can better understand the function of annotations and how they should be formatted. This includes the following annotations.

  • @SDKResource(...)
  • @FrameworkResource(...)
  • @SDKDataSource(...)
  • @FrameworkDataSource(...)
  • @Tags(...)
  • @Testing(...)

The first 4 annotations all have the same format, and should just be documented explicitly. The @Tags annotation should document when the identifier key is used versus the plan annotation with no arguments. The @Testing annotation should document all possible arguments and their function (this may already exist in the tags testing docs, but as contributors will likely be reviewing all annotations together it should likely also be documented wherever this final document is published).

Once complete, this document should serve as the guidelines for implementing annotation linters.

References

No response

Would you like to implement a fix?

None

@jar-b jar-b added the documentation Introduces or discusses updates to documentation. label Feb 21, 2025
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@jar-b jar-b added linter Pertains to changes to or issues with the various linters. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. linter Pertains to changes to or issues with the various linters. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

No branches or pull requests

1 participant