Skip to content

Latest commit

 

History

History
226 lines (138 loc) · 5.61 KB

CONTRIBUTING.md

File metadata and controls

226 lines (138 loc) · 5.61 KB
Raw

Rsbuild Contribution Guide

Thank you for your interest in contributing to Rsbuild! Before you start your contribution, please take a moment to read the following guidelines.

Setup the Environment

Fork the Repo

Fork this repository to your own GitHub account and then clone it to your local.

Branches

  • main -> Rsbuild v1.x
  • v0.x -> Rsbuild v0.x

Install Node.js

We recommend using Node.js 20. You can check your current Node.js version using the following command:

node -v

If you do not have Node.js installed in your current environment, you can use nvm or fnm to install it.

Here is an example of how to install the Node.js 20 LTS version via nvm:

# Install the LTS version of Node.js 20
nvm install 20 --lts

# Make the newly installed Node.js 20 as the default version
nvm alias default 20

# Switch to the newly installed Node.js 20
nvm use 20

Install Dependencies

Enable pnpm with corepack:

corepack enable

Install dependencies:

pnpm install

What this will do:

  • Install all dependencies
  • Create symlinks between packages in the monorepo
  • Run the prepare script to build all packages, powered by nx.

Set Git Email

Please make sure you have your email set up in <https://github.com/settings/emails>. This will be needed later when you want to submit a pull request.

Check that your git client is already configured the email:

git config --list | grep email

Set the email to global config:

git config --global user.email "[email protected]"

Set the email for local repo:

git config user.email "[email protected]"

Making Changes and Building

Once you have set up the local development environment in your forked repo, we can start development.

Checkout A New Branch

It is recommended to develop on a new branch, as it will make things easier later when you submit a pull request:

git checkout -b MY_BRANCH_NAME

Build the Package

Use nx build to build the package you want to change:

npx nx build @rsbuild/core

Build all packages:

pnpm run build

Testing

Add New Tests

If you've fixed a bug or added code that should be tested, then add some tests.

You can add unit test cases in the <PACKAGE_DIR>/tests folder. The test runner is based on Vitest.

Run Unit Tests

Before submitting a pull request, it's important to make sure that the changes haven't introduced any regressions or bugs. You can run the unit tests for the project by executing the following command:

pnpm run ut

You can also run the unit tests of single package:

pnpm run ut packages/core

Run E2E Tests

Rsbuild uses playwright to run end-to-end tests.

You can run the e2e command to run E2E tests:

pnpm run e2e

If you need to run a specified test, you can add keywords to filter:

# Only run test cases which contains `vue` keyword in file path with Rspack
pnpm e2e:rspack vue
# Only run test cases which contains `vue` keyword in test name with Rspack
pnpm e2e:rspack -g vue

Linting

To help maintain consistency and readability of the codebase, we use Biome to lint the codes.

You can run the linters by executing the following command:

pnpm run lint

For VS Code users, you can install the Biome VS Code extension to see lints while typing.

Documentation

You can find the Rsbuild documentation in the website folder.

Submitting Changes

Committing your Changes

Commit your changes to your forked repo, and create a pull request.

Normally, the commits in a PR will be squashed into one commit, so you don't need to rebase locally.

Format of PR titles

The format of PR titles follow Conventional Commits.

An example:

feat(core): Add `myOption` config
^    ^    ^
|    |    |__ Subject
|    |_______ Scope
|____________ Type

Benchmarking

You can input !bench in the comment area of ​​the PR to do benchmarking on rsbuild (you need to have Collaborator and above permissions).

You can focus on metrics related to build time and bundle size based on the comparison table output by comments to assist you in making relevant performance judgments and decisions.

Dependencies installation-related metrics base on publishing process, so the data is relatively lagging and is for reference only.

Versioning

We use [changesets] to manage version. Currently, all Rsbuild packages will use a fixed unified version.

The release notes are automatically generated by GitHub releases.

Releasing

Repository maintainers can publish a new version of all packages to npm.

Here are the steps to publish (we generally use CI for releases and avoid publishing npm packages locally):

  1. Create release pull request.
  2. Run the release action.
  3. Generate the release notes.
  4. Merge the release pull request.