Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Quick Reply Payload data is handle as text message? #43

Open
luizcarvalho opened this issue Nov 13, 2019 · 4 comments
Open

Why Quick Reply Payload data is handle as text message? #43

luizcarvalho opened this issue Nov 13, 2019 · 4 comments

Comments

@luizcarvalho
Copy link
Contributor

Hello guys, in message_event.rb#L26 ['message']['quick_reply']['payload'] is converted in a text message instead of a payload message. I think that if Quick Reply Payload is setted in payload attribute it will be more useful and make more sense, because it are originally a payload.

What do you think?

Thanks guys =D

@mgomes
Copy link
Member

mgomes commented Nov 13, 2019

Hi @luizcarvalho! You are right... I am not sure why I originally implemented as a string.

However, I do have this change already made in an upcoming release. There isn't anything major in it, but I remove support for Cards which were removed in August. I'll close this ticket once that change is merged.

Hope you've been well 👍

@luizcarvalho
Copy link
Contributor Author

My friend @mgomes !!!

Thanks for this.

I'm fine now!
Thanks =D

@cboki
Copy link

cboki commented Nov 28, 2019

Hi guys !
I'm discovering Stealth for a few days and really appreciate working with it !
Thanks for the good work. 😄

Are you sure Cards have been removed in July ? I think Lists have been removed but didn't know for the Cards.

Thank you !

@mgomes
Copy link
Member

mgomes commented Nov 30, 2019

@cboki Thanks for the kind words!

Sorry I misspoke above. Lists were indeed removed, not Cards. Cards are a core part! haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants