Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

-h flags not allowed #248

Open
jdx opened this issue Jul 28, 2017 · 3 comments
Open

-h flags not allowed #248

jdx opened this issue Jul 28, 2017 · 3 comments

Comments

@jdx
Copy link
Contributor

jdx commented Jul 28, 2017

we should either remove -h as a helper to display help, or do the parsing before we display help so that -h is a fallback to help if the command doesn't specify any flags with -h as a char

@RasPhilCo
Copy link
Contributor

@jdxcode you Ok with dropping -h for help (see PR)?

@jdx
Copy link
Contributor Author

jdx commented Oct 6, 2017

actually no, I realize this contradicts what I said before but I feel we should leave -h in. But we should be able to accept -h as a potential argument if it doesn't match anything else. For example:

$ heroku apps:info help # show info for the app 'help'
$ heroku apps:info -h # show info for the app '-h'. not a valid app, but just because something 'looks' like a flag doesn't mean it is one
$ heroku apps:info foo help # display help since info takes 1 arg
$ heroku apps:info foo -h # display help since info takes 1 arg

@jdx
Copy link
Contributor Author

jdx commented Oct 6, 2017

any changes here should probably go into cli-flags instead of the parser in cli-engine-command since that is going away

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants