Outdated docs in README?

[nfedyashev]

Quoting the README:

To test the builds locally:

$ make shell
$ cp bin/nginx-$STACK bin/nginx
$ FORCE=1 bin/start-nginx

make shell
Opening heroku-18 shell...
Unable to find image 'heroku/heroku:18-build' locally
18-build: Pulling from heroku/heroku
171857c49d0f: Pull complete
419640447d26: Pull complete
61e52f862619: Pull complete
c97d646ce0ef: Pull complete
3776f40e285d: Pull complete
44ddde86f2fc: Pull complete
797d95067ecf: Pull complete
Digest: sha256:d3e1d46e2d255b41bec49cd88d9a6c07f7b46daf84298a29cf3333327e1e2ab1
Status: Downloaded newer image for heroku/heroku:18-build

root@3df6d35d05c1:/buildpack# echo $STACK
heroku-18

root@3df6d35d05c1:/buildpack# cp bin/nginx-$STACK bin/nginx
cp: cannot stat 'bin/nginx-heroku-18': No such file or directory

root@3df6d35d05c1:/buildpack# ls bin/
compile  detect  release  start-nginx  start-nginx-debug  start-nginx-solo

root@3df6d35d05c1:/buildpack# ls
Makefile  bin  changelog.md  config  nginx-cedar-14.tgz  nginx-heroku-16.tgz  nginx-heroku-18.tgz  nginx-heroku-20.tgz  readme.md  scripts

Perhaps someone with better knowledge of this buildpack might want to fix it.
HTH

[nfedyashev]

As a workaround
this snippet seemed to work:

$ tar zxvf nginx-$STACK.tgz
./
./nginx
./mime.types
./nginx-debug

$ mv nginx bin/
$ mv mime.types config
$ FORCE=1 bin/start-nginx
buildpack=nginx at=logs-initialized
buildpack=nginx at=start-app cmd=
buildpack=nginx at=exit process=app
buildpack=nginx at=nginx-start

[beanieboi]

hey,

thanks for pointing this out. you are correct, we bundle the assets now and they need to be extracted from the tgz. Would it be possible for you to open a PR to fix the README?

Thank you