-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary right is not preserved with pnpm #1247
Comments
Hi @gregberge, I'm having trouble reproducing this bug to investigate further. Can you provide a bit more information around how you're calling As a quick test, I tried deploying an app using the following {
"name": "issue-1247",
"version": "0.0.0",
"dependencies": {
"odiff-bin": "2.6.1"
},
"engines": {
"node": "20.x"
},
"scripts": {
"build": "odiff tiger.jpg tiger-2.jpg output.jpg"
},
"packageManager": "[email protected]+sha256.0624e30eff866cdeb363b15061bdb7fd9425b17bc1bb42c22f5f4efdea21f6b3"
} The command works though the build step fails because remote: -----> Build
remote: Running build
remote:
remote: > [email protected] build /tmp/build_6711e685
remote: > odiff tiger.jpg tiger-2.jpg output.jpg
remote:
remote: Failure! Images are different.
remote: Different pixels: 7586 (1.137331%)
remote: ELIFECYCLE Command failed with exit code 22. |
We are also running into this issue with sentry/cli. It seems to work when the package is included in dependencies but doesn't work (EACCES) when added in devDependencies. |
@haubey Can you provide details on how you're calling |
@colincasey sure thing. Before
And it worked fine. With the codepack change we removed |
Gently bumping this one. @colincasey any news on that? |
@gregberge the only update here is that I also tried to reproduce the issue using the information provided by @haubey. The results from that are summarized below:
Note The failure at run time when it's installed as a dev dependency is expected since, by default, dev dependencies are pruned at the end of the build. At no point did I observe any To investigate this further, it would help if you could provide some information around how you're calling odiff or share a minimal reproduction of the issue. |
Do y'all by any chance have |
Actually, could it be pnpm/pnpm#6285, or more specifically this: aws/aws-pdk#322 (comment)?
|
@dzuelke we do not have |
I've been able to make a bit of headway here in terms of a minimal reproduction on the Heroku platform. I'm going to record my notes here. Reproducing
Observations
I haven't been able to reproduce the above in a local environment (yet). Only on the Heroku platform. This situation has made isolating a root cause for this behavior more difficult and time consuming. WorkaroundsEither of the following workarounds will prevent the
|
Describe the bug
Using pnpm the binary right is not preserved. For example, the odiff package is broken.
By investigating I found that the underlying binary used in the package has lost its execution right after deploying on Heroku:
To Reproduce
Versions (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: