Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

指令卡分组的缺陷 Deficiencies in getCardGroup #38

Open
hgjazhgj opened this issue Jan 7, 2022 · 1 comment
Open

指令卡分组的缺陷 Deficiencies in getCardGroup #38

hgjazhgj opened this issue Jan 7, 2022 · 1 comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@hgjazhgj
Copy link
Owner

hgjazhgj commented Jan 7, 2022

当自己的从者和助战的有相同的指令卡头像时会无法将指令卡分在两个组,由于指令卡上的助战标志在buff图标很多时会被遮挡,这个问题难以修复
这导致选卡的结果不是最优的
When your servant and the support one has the same command card portrait, getCardGroup will see them as in the same group, which is not true and hard to fix, because the support tag on a command card might be covered when there are many buff icons
This problem causes selectCard to not provide the best solve

@hgjazhgj hgjazhgj added help wanted Extra attention is needed bug Something isn't working enhancement New feature or request labels Jan 7, 2022
@hgjazhgj hgjazhgj removed help wanted Extra attention is needed labels Jun 30, 2022
@hgjazhgj
Copy link
Owner Author

hgjazhgj commented Jul 8, 2022

getCardGroup将被弃用,变为getCardServant,返回从者编号或在场成员中的序号,此时识别一张指令卡是否为助战仍是需要的

@hgjazhgj hgjazhgj closed this as completed Jul 3, 2023
@hgjazhgj hgjazhgj reopened this Aug 24, 2023
@hgjazhgj hgjazhgj added the help wanted Extra attention is needed label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant