Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetuning Base Model on chat data should change "eos_token" to "<|im_end|> #7454

Open
1 task done
mertunsall opened this issue Mar 24, 2025 · 0 comments
Open
1 task done
Labels
enhancement New feature or request pending This problem is yet to be addressed

Comments

@mertunsall
Copy link

mertunsall commented Mar 24, 2025

Reminder

  • I have read the above rules and searched the existing issues.

Description

I ran a finetuning job on a pretrained base model such as https://huggingface.co/Qwen/Qwen2.5-Math-7B with chat style data. Then, when I try to do generation with vllm with default settings, the model doesn't stop generating as the "eos_token" parameter of the base model is <|end_of_text|> instead of <|im_end|> (which is the case for the instruct model).

I suggest this should be automatically changed for the finetuned model's config, but I don't know if there is a general way to do this. I believe one can simply change the "eos_token" to whatever was used in the chat template as the end token.

Pull Request

No response

@mertunsall mertunsall added enhancement New feature or request pending This problem is yet to be addressed labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending This problem is yet to be addressed
Projects
None yet
Development

No branches or pull requests

1 participant