Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prettier formatter in tests #403

Open
2 of 3 tasks
verdverm opened this issue Dec 28, 2024 · 0 comments
Open
2 of 3 tasks

Update Prettier formatter in tests #403

verdverm opened this issue Dec 28, 2024 · 0 comments

Comments

@verdverm
Copy link
Member

verdverm commented Dec 28, 2024

Situation:

  • The prettier SDK changed the API between v2 & 3.
  • we hard code the formatter version in the general GHA workflow, so we don't use the one built on the current commit (we don't often run the action that builds formatters because they are so flakey...)

To upgrade, we need to

  • update the formatter and publish a new version, expecting a build failure in the release tag build
  • update the pinned version to v0.6.10-rc.2 for the v0.6.10 release
  • update the pinned version to v0.6.10 after the release has been cut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant