Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce OSCMessageBuilder #42

Open
hoijui opened this issue Apr 25, 2019 · 4 comments
Open

Introduce OSCMessageBuilder #42

hoijui opened this issue Apr 25, 2019 · 4 comments

Comments

@hoijui
Copy link
Owner

hoijui commented Apr 25, 2019

In order to make OSCMessage an immutable object (all fields final), while still having a comfortable way to create messages, we could simply use the builder pattern, like in OSCPortInBuilder.java

This is related to the concurrency issue #4.

@T-Roel
Copy link

T-Roel commented Dec 29, 2024

Good afternoon @hoijui is this issue still necessary to be implemented? I'd like to contribute with the project and I think it will be good to start with it. If you believe it's not necessary, I'd like to know if you recommend another one :) Thanks in advance!

@hannesa2
Copy link
Contributor

hannesa2 commented Dec 29, 2024

If @hoijui is interested on further development, all is fine. Only the merge of existing pull requests is an open task.
I at least made 2 pull requests to see if a further contribution makes sense here.

But if he is no more interested, it would be fair to give an additional maintainer the power to merge, because the community is at least interested.
Let's see, if we get an answer....

@hoijui
Copy link
Owner Author

hoijui commented Dec 30, 2024

@T-Roel , Sure, please!
Feel free to do so!
Also.. and of the other collaborators, feel free to deal with the resulting PR without my interaction.

@T-Roel
Copy link

T-Roel commented Dec 30, 2024

Thanks to answer back @hoijui I'll take a look at this issue and will apply the resquested changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants