Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash prefix in base64 excludes the "u" character that HoloHashB64 prepends #531

Open
mattyg opened this issue Feb 12, 2025 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@mattyg
Copy link
Member

mattyg commented Feb 12, 2025

What is incorrect

The base64 hash prefixes are correct, but missing the "u" character that HoloHashB64 expects.

This is explained in the rust docs page: https://docs.rs/hdi/latest/hdi/hash/index.html#self-identifying-hash-encoding

My suggestion is to include that rust docs page in the "References" section.

Link to page

https://developer.holochain.org/build/identifiers

@mattyg mattyg added the enhancement New feature or request label Feb 12, 2025
@mattyg mattyg added this to Holochain Feb 12, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Holochain Feb 12, 2025
@mattyg
Copy link
Member Author

mattyg commented Feb 12, 2025

Actually this is covered in the rust docs, so I'd say its probably not necessary to expand upon here: https://docs.rs/hdi/latest/hdi/hash/index.html#self-identifying-hash-encoding

@mattyg mattyg closed this as completed Feb 12, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Holochain Feb 12, 2025
@mattyg
Copy link
Member Author

mattyg commented Feb 12, 2025

Looks like that rust docs page is not linked to from this page, so reopening this issue and renaming to just link to that page.

@mattyg mattyg reopened this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant