Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux plugin build and install broken #53

Open
grondo opened this issue May 23, 2024 · 2 comments
Open

flux plugin build and install broken #53

grondo opened this issue May 23, 2024 · 2 comments

Comments

@grondo
Copy link
Member

grondo commented May 23, 2024

It appears that in c3ef9a2 some of the autotools setup for the Spindle Flux plugin was removed.

Unfortunately, this breaks proper (or perhaps more correctly _convenient) installation of the Flux plugin. Things that would help the install of the flux plugin include:

  • It is customary for plugins to not have a lib prefix, e.g. the Flux plugin should be spindle.so. This matches how Flux expects plugins to be named, but isn't critical if there is a reason Spindle wants the lib prefix.
  • The plugin should be installed by default to the Flux shell pluginpath (this was previously captured and defined in configure.ac). For a spack package or side install, a flux shell spindle.lua rc file should be installed and added to FLUX_SHELL_RC_PATH.

I'm also not seeing any checks for libflux-core.so and libflux-hostlist.so, but I must be missing this because the flux plugin is built with these libs and FLUX_CORE_LIBS and FLUX_CORE_CFLAGS etc are defined in the Makefiles, so I apologize if I missed something obvious.

@mplegendre
Copy link
Member

I'm cautious about going to spindle.so for the flux plugin. Spindle already has a libspindle.so for its user interface library, and mixing those names could be confusing. Could we symlink a spindle.so in the flux plugin space to a libspindleflux.so in the spindle space?

Will investigate the pluginpath issue.

@grondo
Copy link
Member Author

grondo commented May 24, 2024

Eh, like I said the naming isn't critical, by default the Flux job shell will load *.so from the plugin search path, so either fluxspindle.so or libfluxspindle.so would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants