Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export of inconsistent internal headers #549

Open
drabmart opened this issue May 19, 2023 · 1 comment
Open

Export of inconsistent internal headers #549

drabmart opened this issue May 19, 2023 · 1 comment

Comments

@drabmart
Copy link

The header file mfu_flist_internal.h gets installed (distributed) with the compiled library. (Is this intentional? Why is it called "internal" then?) Anyway, unfortunatelly it is being included by the utils/tools/h5dwalk/h5dwalk.c file (from the HDF5 1.14 project). However, mfu_flist_internal.h unconditionally includes strmap.h, which is not being installed. And that is an error. Either both or none of them should be installed (distributed). If the functions/structures in the mfu_flist_internal.h are supposed to be used externally (like apparently they are in HDF5), then strmap.h has to be installed (distributed) too.

@adammoody
Copy link
Member

Yes, good point. Thanks for the report, @drabmart . The original intent was not to distribute internal headers, but then we did so since it made it easier for others to develop new tools using the libmfu library. I think including strmap.h was then overlooked. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants