Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run results error #783

Merged
merged 9 commits into from
Oct 3, 2024
Merged

Run results error #783

merged 9 commits into from
Oct 3, 2024

Conversation

hwikle-lanl
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl linked an issue Aug 23, 2024 that may be closed by this pull request
run_result being accessed before assignment. #781
Closed
@hwikle-lanl hwikle-lanl self-assigned this Aug 23, 2024
francinelapid
francinelapid requested changes Sep 18, 2024
View reviewed changes
lib/pavilion/commands/_run.py Outdated Show resolved Hide resolved
@hwikle-lanl
Fix failing pylint tests in CI
7754b6e
@hwikle-lanl
Second try
bb7565d
@hwikle-lanl
Fix newly failing style tests
c76fc76
@hwikle-lanl
Update workflow file
92006ce
@hwikle-lanl
Try something else
c3c9ab3
@hwikle-lanl
Initial attempt to fix Nick's problem
2df210e
@hwikle-lanl
Exit immediately on raising error
a48009f 
The _run error handling in the _run function was causing it
to continue onto gather results even after TestRun.run had
failed, but was trying to use a variable that hadn't been created
due to the error handing. This commit simply changes _run to
exit on an error instead of continuing on to resul parsing.
@hwikle-lanl
Implement PR feedback
caa5f24
@hwikle-lanl
Increase timeout for test_owner
c8e6d93
@francinelapid francinelapid merged commit b443746 into develop Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelapid francinelapid francinelapid approved these changes

@Paul-Ferrell Paul-Ferrell Awaiting requested review from Paul-Ferrell

Assignees

@hwikle-lanl hwikle-lanl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run_result being accessed before assignment.
2 participants
@hwikle-lanl @francinelapid