Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error instead of panicing when server not ready #132

Open
karlmdavis opened this issue Aug 8, 2020 · 1 comment
Open

Return error instead of panicing when server not ready #132

karlmdavis opened this issue Aug 8, 2020 · 1 comment

Comments

@karlmdavis
Copy link

I'm running into an assert!(...) here, which should probably just return an error, instead: https://docs.rs/async-h1/2.1.2/src/async_h1/client/decode.rs.html#32

(I think that's what the TODO there is suggesting.)

In this case, I know that the server I'm querying may not be up yet -- I'm issuing requests in a loop with a timeout, for the purpose of waiting for the server to come up all the way.

@karlmdavis
Copy link
Author

Just a heads-up for others: this may now be fixed: https://docs.rs/async-h1/2.3.2/src/async_h1/client/decode.rs.html#32.

I haven't had a chance to test it yet, but the code looks like it's doing the right thing now, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant