You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently our handling of HTTP/1.0 connections is rather blunt: we log an error and exit. We could do better by sending back a 426: Upgrade Required header with an Upgrade: HTTP/1.1 field. A client that sends an HTTP/1.0 request will receive a more informative response that's not "TCP connection aborted", and if it's sufficiently advanced it may even know to upgrade to HTTP/1.1 and try again.
We may choose to add support for HTTP/1.0 proper in the future. But that requires a significant amount of design work and research, and until then we can at least ensure we fail more gracefully when detecting HTTP/1.0 connections.
response payload
HTTP/1.0 426 Upgrade Required Upgrade: HTTP/1.1Connection: Upgrade Content-Length: 53Content-Type: text/plain This service requires use of the HTTP/1.1 protocol.
The text was updated successfully, but these errors were encountered:
yoshuawuyts
changed the title
gracefully handle HTTP/1.0 connections
gracefully fail HTTP/1.0 connections
Nov 5, 2020
@jbr oh yeah, that's entirely reasonable -- and with HTTP/1.0 support enabled by setting the host, there's definitely a clear path to "upgrading". Albeit through a somewhat more manual approach.
jbr
linked a pull request
Jan 25, 2021
that will
close
this issue
Currently our handling of HTTP/1.0 connections is rather blunt: we log an error and exit. We could do better by sending back a 426: Upgrade Required header with an
Upgrade: HTTP/1.1
field. A client that sends an HTTP/1.0 request will receive a more informative response that's not "TCP connection aborted", and if it's sufficiently advanced it may even know to upgrade toHTTP/1.1
and try again.We may choose to add support for HTTP/1.0 proper in the future. But that requires a significant amount of design work and research, and until then we can at least ensure we fail more gracefully when detecting HTTP/1.0 connections.
response payload
The text was updated successfully, but these errors were encountered: