Support MySQL #18

waste-of-kindergarten · 2024-11-20T15:32:47Z

resolve #17

…gresql" directory

…dDatabaseConnectPostgresql` to `exposedDatabaseConnectMysql`

ShreckYe · 2024-11-29T15:10:14Z

I merged dev-dependent-on-snapshots into main and deleted the dev-dependent-on-snapshots branch, and it seems this PR was automatically closed. I pushed the dev-dependent-on-snapshots branch back so I could reopen this PR, and changed the merge target to main.

ShreckYe · 2024-11-29T15:18:46Z

Please merge from main to get the latest changes. After that, you won't need to run publishToMavenLocal in the dependency projects anymore. And please see the changes in the "postgresql" module since this branch was created, and update the "mysql" module correspondingly. In IntelliJ IDEA, you can right click on the "postgresql" directory and use "Git -> Compare with Branch..." to do this.

…r discussion required

ShreckYe

Please use "Mysql" in our own code.

mysql/src/main/kotlin/com/huanshankeji/exposedvertxsqlclient/mysql/exposed/ExposedDatabases.kt

.../src/main/kotlin/com/huanshankeji/exposedvertxsqlclient/mysql/local/LocalConnectionConfig.kt

…h main (commit 61b52b9)

…1b0d3 and port them to "mysql"

mysql/build.gradle.kts

Co-authored-by: Yongshun Shreck Ye <[email protected]>

bf1b0d3

…code

…ld.gradle.kts"

sonarqubecloud · 2025-01-18T11:50:53Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ShreckYe

Some code is not completely adapted. Try searching the words "pg" and "postgre" in the "mysql" directory to make sure no PostgreSQL code is not adapted.

ShreckYe · 2025-01-18T11:51:57Z

mysql/src/main/kotlin/com/huanshankeji/exposedvertxsqlclient/mysql/DatabaseClient.kt

+import io.vertx.sqlclient.Pool
+import io.vertx.sqlclient.SqlConnection
+
+suspend fun <T> DatabaseClient<Pool>.withSQLTransaction(function: suspend (DatabaseClient<SqlConnection>) -> T): T =


This one should be withMysqlTransaction and the connection type should be MySQLConnection.

ShreckYe · 2025-01-18T11:54:08Z

mysql/src/main/kotlin/com/huanshankeji/exposedvertxsqlclient/mysql/exposed/ExposedDatabases.kt

+    )
+
+@ExperimentalEvscApi
+@JvmName("exposedDatabaseConnectMySQLWithParameterConnectionConfig")


Suggested change

@JvmName("exposedDatabaseConnectMySQLWithParameterConnectionConfig")

@JvmName("exposedDatabaseConnectMysqlWithParameterConnectionConfig")

ShreckYe · 2025-01-18T11:54:52Z

...c/main/kotlin/com/huanshankeji/exposedvertxsqlclient/mysql/vertx/mysqlclient/MysqlClients.kt

+ */
+// made not inline anymore for easier debugging
+@ExperimentalEvscApi
+fun <SqlClientT : SqlClient, ClientBuilderT : ClientBuilder<SqlClientT>> createGenericPgClientWithBuilder(


"Mysql" not "Pg".

ShreckYe · 2025-01-18T11:55:18Z

...c/main/kotlin/com/huanshankeji/exposedvertxsqlclient/mysql/vertx/mysqlclient/MysqlClients.kt

+        MySQLPoolOptions(PoolOptions()) // remain to verify
+    )
+
+fun createPgClient(


"Mysql" not "Pg".

ShreckYe · 2025-01-18T11:55:26Z

...c/main/kotlin/com/huanshankeji/exposedvertxsqlclient/mysql/vertx/mysqlclient/MysqlClients.kt

+/**
+ * @see createGenericSqlClient
+ */
+fun createPgPool(


"Mysql" not "Pg".

ShreckYe · 2025-01-18T11:55:56Z

...c/main/kotlin/com/huanshankeji/exposedvertxsqlclient/mysql/vertx/mysqlclient/MysqlClients.kt

+ * @see createGenericSqlClient
+ */
+@Untested
+suspend fun createPgConnection(


"Mysql" not "Pg".

ShreckYe · 2025-01-18T11:58:38Z

This PR is basically complete. We should just wait for #23 to be resolved to merge this.

ShreckYe added 2 commits November 20, 2024 23:06

Add the MySQL module with the "mysql" directory copied from the "post…

ce50f6d

…gresql" directory

Change the Vert.x SQL Client dependency to MySQL and refactor `expose…

d4ddc19

…dDatabaseConnectPostgresql` to `exposedDatabaseConnectMysql`

waste-of-kindergarten requested a review from ShreckYe November 20, 2024 15:35

ShreckYe force-pushed the mysql branch from 0cd8c15 to d4ddc19 Compare November 20, 2024 16:03

ShreckYe deleted the branch main November 29, 2024 15:04

ShreckYe closed this Nov 29, 2024

ShreckYe reopened this Nov 29, 2024

ShreckYe changed the base branch from dev-dependent-on-snapshots to main November 29, 2024 15:08

Update MySQLClients.kt but some problems may be raised, thus a furthe…

bf1b0d3

…r discussion required

ShreckYe requested changes Jan 18, 2025

View reviewed changes

Merge branch 'main' into mysql

fb229d0

ShreckYe force-pushed the mysql branch from 213cdc0 to fb229d0 Compare January 18, 2025 07:45

ShreckYe and others added 3 commits January 18, 2025 16:00

Revert some mistaken changes in commit bf1b0d3 comparing the code wit…

cff15d4

…h main (commit 61b52b9)

Use "Mysql" in our own code as @ShreckYe suggested

89d6913

Review the changes in "postgresql" in the main branch since commit bf…

f54e251

…1b0d3 and port them to "mysql"

ShreckYe requested changes Jan 18, 2025

View reviewed changes

mysql/build.gradle.kts Outdated Show resolved Hide resolved

waste-of-kindergarten and others added 2 commits January 18, 2025 09:38

Update mysql/build.gradle.kts

48cff78

Co-authored-by: Yongshun Shreck Ye <[email protected]>

Run apiDump.

af1e640

waste-of-kindergarten marked this pull request as ready for review January 18, 2025 08:51

ShreckYe self-assigned this Jan 18, 2025

ShreckYe added 4 commits January 18, 2025 17:22

Rename some directories back, reverting some mistaken changes in commit

26e37b2

bf1b0d3

Rename MysqlClients.kt, reformat the code, and remove some redundant …

2def01b

…code

Update "mysql/build.gradle.kts" to be consistent with "postgresql/bui…

6d74537

…ld.gradle.kts"

Run apiDump

893788d

ShreckYe requested changes Jan 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support MySQL #18

Support MySQL #18

waste-of-kindergarten commented Nov 20, 2024

ShreckYe commented Nov 29, 2024 •

edited

Loading

ShreckYe commented Nov 29, 2024 •

edited

Loading

ShreckYe left a comment •

edited

Loading

sonarqubecloud bot commented Jan 18, 2025

ShreckYe left a comment

ShreckYe Jan 18, 2025

ShreckYe Jan 18, 2025

ShreckYe Jan 18, 2025

ShreckYe Jan 18, 2025

ShreckYe Jan 18, 2025

ShreckYe Jan 18, 2025

ShreckYe commented Jan 18, 2025 •

edited

Loading

	@JvmName("exposedDatabaseConnectMySQLWithParameterConnectionConfig")
	@JvmName("exposedDatabaseConnectMysqlWithParameterConnectionConfig")

Support MySQL #18

Are you sure you want to change the base?

Support MySQL #18

Conversation

waste-of-kindergarten commented Nov 20, 2024

ShreckYe commented Nov 29, 2024 • edited Loading

ShreckYe commented Nov 29, 2024 • edited Loading

ShreckYe left a comment • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 18, 2025

Quality Gate passed

ShreckYe left a comment

Choose a reason for hiding this comment

ShreckYe Jan 18, 2025

Choose a reason for hiding this comment

ShreckYe Jan 18, 2025

Choose a reason for hiding this comment

ShreckYe Jan 18, 2025

Choose a reason for hiding this comment

ShreckYe Jan 18, 2025

Choose a reason for hiding this comment

ShreckYe Jan 18, 2025

Choose a reason for hiding this comment

ShreckYe Jan 18, 2025

Choose a reason for hiding this comment

ShreckYe commented Jan 18, 2025 • edited Loading

ShreckYe commented Nov 29, 2024 •

edited

Loading

ShreckYe commented Nov 29, 2024 •

edited

Loading

ShreckYe left a comment •

edited

Loading

ShreckYe commented Jan 18, 2025 •

edited

Loading