-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Following _Awesome_ guidelines #45
Comments
Thanks for trying to get it into the list. I ran the
I'm not really inclined to spend time fixing each of these to bring the list in line with what seem to be quite extensive and rather opinionated guidelines, especially when I think some of the deviations are useful, such as the links to mobile apps and some of the double links. |
I see, yeah there are a lot of rule violations. But are you saying you won't fix all of the issues? Because I think that is a requirement to be listed on the main awesome list. |
I think some of the deviations improve the list and I don't see why the
guidelines have to be so prescriptive so I'm not inclined to spend much
time trying to comply.
But I'll accept PRs that resolve the formatting issues or that bring the
list in line whilst retaining the improvements (e.g. the direct links to
the mobile app stores).
…On Sun, 13 Aug 2023, 19:26 Edwin Kofler, ***@***.***> wrote:
I see, yeah there are a lot of rule violations. But are you saying you
won't fix all of the issues? Because I think that is a requirement to be
listed on the main awesome list.
—
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRYR4KBS5D7A53WGNMGKVDXVC2VXANCNFSM6AAAAAA3ONHAZY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Yeah there are some lints I maybe disagree with, but it's part of the requirements. I'm looking at the list and it seems you would also have to change your default branch to |
I guess that is your decision then to retain some improvements while violating the admittedly strict awesome guidelines? It doesn't look like they are lenient with any repositories they accept... |
What's the issue?
I'm the author of this pr to update the Awesome Mastodon link to this fork, but what I didn't know is that some guidelines here are not followed (blocking the PR).
Should things be updated to fix this?
The text was updated successfully, but these errors were encountered: