Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padding_side is of type bool when it should be Literal['right', 'left'] #36252

Open
4 tasks
winstxnhdw opened this issue Feb 18, 2025 · 1 comment
Open
4 tasks
Labels

Comments

@winstxnhdw
Copy link
Contributor

winstxnhdw commented Feb 18, 2025

System Info

main branch

Who can help?

@amyeroberts

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

https://github.com/huggingface/transformers/blob/main/src/transformers/tokenization_utils_base.py#L2816

Expected behavior

Should be Literal['right', 'left'] as mentioned in the docs.

https://huggingface.co/docs/transformers/en/main_classes/tokenizer#transformers.PreTrainedTokenizerFast.__call__.padding_side

@winstxnhdw winstxnhdw added the bug label Feb 18, 2025
@zucchini-nlp
Copy link
Member

@winstxnhdw oops, that's a typo. Can you open a PR to fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants