Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IX] Edit of Entities in regular Uwazi flow #7142

Open
RafaPolit opened this issue Aug 21, 2024 · 4 comments
Open

[IX] Edit of Entities in regular Uwazi flow #7142

RafaPolit opened this issue Aug 21, 2024 · 4 comments

Comments

@RafaPolit
Copy link
Member

Edit of Entities in regular Uwazi flow

Currently, editing an entity (at least the tile), does not reflect on the Metadata Extraction panel. When you edit a title inside an entity and go back into the extractor, the values listed are the previous ones. Is this expected? What is the flow of editing the entity inside and outside of IX Panel.

@txau
Copy link
Collaborator

txau commented Aug 21, 2024

That is a very good point. While having a good 1-1 relationship with the titles is important, it is not critical. On the other hand other updates are critical:

  • The entity was deleted
  • The value of the property the extractor is pointing to changed
  • The entity has a new document

@RafaPolit
Copy link
Member Author

RafaPolit commented Aug 21, 2024

How is this not critical? If I have an entity named "Original Name" with a document and an extractor configured for Title, I go into the extractor and see:

DOCUMENT Context Current Value / Suggested value
Original Name Bla, bla Original Name / Suggested Name

Now, I go into the entity, change the name to "New Name", go into the extractor and see EXACTLY the same thing as before.

I now have no idea which entity (and again the document vs entity dilema mentioned in the other issue) was "Original Name". I have no entity named "Original Name" in my collection.

I think this is the case of your second bullet point, with the added problem that the column use to reference the entity has also changed (that is, both the value of the property the extractor is pointing to, but also the property used to identify the row, which in this case are the same)

@txau
Copy link
Collaborator

txau commented Aug 21, 2024

It is not critical because:

  • It only affects titles
  • Users are not changing title around often
  • When users retrain, all these titles get updated

So yes, this can happened and is not desirable, but it is not critical. That said, if we need to trigger automatic updates on the suggestions when other of the data changes (ie. the scenarios I mentioned above), then sure, let's fix it along with the rest of the cases.

@RafaPolit
Copy link
Member Author

Check that changing properties OTHER than title is also leaving obsolete data in the current values, or if they are updating correctly and it is only Title that has this peculiarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants