Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

story: As an owner of a hypercert, I want to be able to link and update images that are displayed on sponsorship billboards. #917

Closed
8 of 10 tasks
holkexyz opened this issue Jun 28, 2023 · 5 comments

Comments

@bitbeckers
Copy link
Contributor

@benedictvscriticus food for cleanup

@benedictvscriticus benedictvscriticus changed the title feat: owners of hypercerts can link and update images that are displayed on sponsorship billboards story: As an owner of a hypercert, I want to be able to link and update images that are displayed on sponsorship billboards. Oct 19, 2023
@benedictvscriticus
Copy link

@holkeb said on Jun 29:

Issue #915 describes updating the treemap, such that images are displayed.

This issue describes how the billboard can access these images and how hypercert owners can choose the images.

Expected behavior

  • Hypercert owner can choose and update which image will be displayed on the sponsorship billboard of a hypercert
  • Hypercert owner can choose and update which image will be displayed on a sponsorship billboard of a hypercert if she didn't specify an image for this hypercert specifically (default image of hypercert owner)
  • The billboard displays the newest associated image in the space that is allocated to the hypercert owner

Suggested solution

  • Create a database with the following columns: wallet address, hypercert identifier, link to image
  • Create a form to allow hypercert owners to add an entry to the database linking a new images to their address for specific hypercerts
  • Create a form to allow hypercert owners to add an entry to the database linking a new default image to their address with an empty entry for the hypercert identifier
  • The billboard looks for the newest image that is associated with the owner address and the hypercert. If no image is linked to the owner address and hypercert, the billboard looks for the default image of the owner address, i.e. the newest image associated with the owner address with an empty entry for the hypercert identifier
  • Ideally a hypercert owner can easily upload a new image and doesn't need to do that in a separate step as it is currently done when creating a hypercert

Open questions

  • Do we need different image sizes and proportions for different spaces?

@Jipperism
Copy link
Contributor

@holkeb @benedictvscriticus is this the implementation we want to go with for now? I think for v1, it might be sufficient to just have a 2 tiered approach? E.g. hyperboard owner can upload default sponsor_metadata per address. Hypercert owners can overwrite this once they've claimed the cert, if they desire to do so.

@holkexyz
Copy link
Member Author

Yes, for now it is ok if one address is linked to one image, but we want more flexibility later

@bitbeckers
Copy link
Contributor

@Jipperism @holkexyz this is currently in hyperboards, correct? If not, feel free to reopen and assign it on the roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants