Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Metadata not uploaded to IPFS consistently #940

Open
bitbeckers opened this issue Jul 12, 2023 · 5 comments
Open

[SDK] Metadata not uploaded to IPFS consistently #940

bitbeckers opened this issue Jul 12, 2023 · 5 comments
Labels
p1:ready Ready for work

Comments

@bitbeckers
Copy link
Contributor

Which area(s) of Hypercerts are affected? (leave empty if unsure)

SDK

To Reproduce

Review the hypercerts I've created: https://testnets.opensea.io/0x1C9F765C579F94f6502aCd9fc356171d85a1F8D0?search[sortAscending]=false&search[sortBy]=CREATED_DATE

Some have URIs that render on OpenSea, others don't:
159592430085920139364322690885499291172867: bafybeia2jw3oik5sp6l5rfvs54tgi3hylqvfl3igjtm3twc5kroz6hoaeq
158571582985157323973932567063203986538497: bafybeieba7srhdynfgy5qidrc4jiwdgp4p2c4c5jykhougstfaeqv3roqe

Describe the Bug

Some metadata is parsed and rendered by OpenSea, some isn't. They do render in the dApp

Expected Behavior

All hypercert metadata should render

@bitbeckers bitbeckers assigned bitbeckers and ryscheng and unassigned ryscheng Jul 12, 2023
@bitbeckers bitbeckers added p0:urgent Must address immediately p1:ready Ready for work and removed p0:urgent Must address immediately labels Jul 12, 2023
@ryscheng
Copy link
Member

This is.... weird!

I see the image is in the metadata, and I'm able to open those data URL links manually in my browser.
So opensea has issues with some image URLs?

@bitbeckers
Copy link
Contributor Author

OpenSea is very strict in their parsing. Some missing value or an empty [] and they just don't show the metadata. We might be more lenient and know what we expect. So my strategy will be comparing metadatasets and finding the differences

@bitbeckers
Copy link
Contributor Author

Been inspecting the metadata and the only difference thus far is the "external_url" being present or not:

  • JSON loads
  • Image can be decoded and rendered
  • Hypercert dimensions and allowlists are present

@benedictvscriticus
Copy link

@bitbeckers can you give me some more context for this please?

@holkexyz
Copy link
Member

@bitbeckers is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1:ready Ready for work
Projects
Status: No status
Development

No branches or pull requests

4 participants