Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMAIN_NAME environment variable not working #47

Open
guillian77 opened this issue Jun 11, 2021 · 1 comment
Open

DOMAIN_NAME environment variable not working #47

guillian77 opened this issue Jun 11, 2021 · 1 comment

Comments

@guillian77
Copy link

guillian77 commented Jun 11, 2021

Hi, thanks a lot for your great work.

I am trying to specify custom DNS by using DOMAIN_NAME environment variable but it did not work.
I read your code a bit and I have debugging something interresting.

// src/Synchronizer.php:120
// Global
if (!empty($container['NetworkSettings']['IPAddress'])) {
    $ip = $container['NetworkSettings']['IPAddress'];

    $lines[$ip] = implode(' ', $this->getContainerHosts($container));
}

For me this condition cannot be true because $container['NetworkSettings']['IPAddress'] is null or empty.

I just move $lines[$ip] = implode(' ', $this->getContainerHosts($container)); to line 130 just after $ip declaration and it work great.

I don't know if it's really a bug or this problem come from my setup.

Maybe I have to specify an other thing to make it work ?

Docker version 20.10.6, build 370c289
docker-compose version 1.28.6, build 5db8d86f

Best regards

@iamluc
Copy link
Owner

iamluc commented Jun 11, 2021

Hi,

See #34. There is a long discussion about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants