Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor/Developer feedback #44

Open
mabrinasueller opened this issue Feb 23, 2024 · 0 comments
Open

Editor/Developer feedback #44

mabrinasueller opened this issue Feb 23, 2024 · 0 comments

Comments

@mabrinasueller
Copy link
Contributor

mabrinasueller commented Feb 23, 2024

Already in work:

  • In general, it is not clear which components are available or which ones I, as an editor, can use. The best approach would be a template collection with an explanation of how they work and example content sidekick library #31
  • An element like the divider was not understandable to me in terms of how to insert it. I copied it from another page, but I wouldn't know how to create it myself. I am not highly proficient in Google Docs, and real users might not be either. Proof if you can add page in library, not just blocks, with default content sidekick library #31
  • What icons are available for the Features component? Can editors independently add icons? Icons overview #17
  • If there is a fixed selection of icons, a legend with clear names for the icons would be beneficial. Icons overview #17
  • The Table component is inserted in "Generic" but does not exist yet and causes errors on the page (e.g., the divider is not resolved correctly). Test/iza #8
  • Errors in components significantly slow down the page.-> clear console errors ticket Error Handling #36
  • Split block.service.ts further into individual functions/helpers, and use more specific variable names. main.ts refactor #33
  • The code relies on a specific order of elements; can this always be guaranteed? For example, the banner. sidekick library #31 -> evaluation ticket error handling?
  • Error handling? Error Handling #36

Medium priority:

  • Button component outside of banner Ticket for button component
  • Metadata is not displayed correctly on the "About" page. -> create ticket: check behavior of metadata, especially description

Low priority:

  • Without the divider, there was little to no spacing between components on a page. Create ticket
  • Embedding internal links is confusing: suggested articles lead to the preview page only. -> maybe research for other solution, otherwise provide good documentation
  • Project setup: "npm start" + "npm run build" should be added to the Readme
  • Grids are not correctly rendered on all breakpoints for posts (e.g., largest breakpoint, lines not rendered after the second row). Could be obsolet if a maximum of 6 posts are displayed
  • Unit testing with Jest? -> at this point just planned for utils
  • Customization options for clients? For CI, colors, icons, etc.
  • dist folder not in .gitignore file -> ticket for better solution for dist folder (right now included because of AEM bot on github)

No priority/not relevant:

  • Font colors are not displayed
  • Links always rendered in red
  • Images: The height limitation to 400px distorts many of the images and does not make them look good due to the cropping
  • How to handle multiple images on a page? Create metadata for each individual image?
  • Is there a way to adjust the document structure on the side to reflect the components? Currently, only Title and paragraph are represented. Maybe I am thinking too much in terms of containers due to working with other CMS
  • What if clients want to customize the layout? For example, remove lines between contact information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

1 participant