Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows ssl functionality in addition to openssl #52

Open
andre2007 opened this issue Aug 8, 2017 · 5 comments
Open

Add windows ssl functionality in addition to openssl #52

andre2007 opened this issue Aug 8, 2017 · 5 comments

Comments

@andre2007
Copy link

Please add the option to use windows ssl functionality in addition to openssl. There are two major benefits:

  • No need to copy / package openssl libraries
  • In case there are implementation issues with the windows ssl library, these issue will be solved automatically by Microsoft with the next update. In case of openssl, the corrected library has to be shipped to all customers using the application
@GeirGrusom
Copy link

GeirGrusom commented Mar 5, 2018

The documentation also needs to describe how that issue is resolved. It's not really acceptable that the application cannot query https resources, but there is no description of the error or how to resolve it. Simply copying OpenSSL dlls doesn't seem to work.

dub\packages\requests-0.7.2\requests\source\requests\ssl_adapter.d:_staticCtor38:66 warning: failed to load libssl - first access over https will fail

@ikod
Copy link
Owner

ikod commented Mar 5, 2018

Hello, @GeirGrusom

I need a bit more info - did you installed openssl? Simply copying might not work.

@GeirGrusom
Copy link

I got it to work; I renamed ssleay32.dll to libssl32.dll. But it would still be nice with a Windows implementation that didn't require OpenSSL :)

@ikod
Copy link
Owner

ikod commented Mar 5, 2018

nice to hear,
as for Windows implementation of SSL - I have almost absolute zero experience with programming for Windows, so... (I'm waiting for any brave contributor :)

@GeirGrusom
Copy link

Thank you for this library anyway, you've done a good job!

To not come off as a whiny github issue commentor I could take a stab at this, but between billable hours and family time I'm stretched fairly thin so no promises :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants