Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: re-enable node 4 and 5 tests #2053

Open
ljharb opened this issue May 13, 2021 · 4 comments · May be fixed by #3091
Open

Tests: re-enable node 4 and 5 tests #2053

ljharb opened this issue May 13, 2021 · 4 comments · May be fixed by #3091
Labels
build-process

Comments

@ljharb
Copy link
Member

ljharb commented May 13, 2021 •
edited
Loading

They are likely legitimately failing right now, but we need to unblock a release.
@ljharb ljharb changed the title Tests Tests: re-enable node 4 and 5 tests May 13, 2021
ljharb added a commit to ljharb/eslint-plugin-import that referenced this issue May 13, 2021
@ljharb
[Tests] temporarily disable node 4 and 5 tests
54fb21f 
See import-js#2053
ljharb added a commit to ljharb/eslint-plugin-import that referenced this issue May 13, 2021
@ljharb
[Tests] temporarily disable node 4 and 5 tests
af142ba 
See import-js#2053
ljharb added a commit to ljharb/eslint-plugin-import that referenced this issue May 13, 2021
@ljharb
[Tests] temporarily disable node 4 and 5 tests
9956bfb 
See import-js#2053
ljharb added a commit to ljharb/eslint-plugin-import that referenced this issue May 13, 2021
@ljharb
[Tests] temporarily disable node 4 and 5 tests
38103d3 
See import-js#2053
ljharb added a commit to ljharb/eslint-plugin-import that referenced this issue May 13, 2021
@ljharb
[Tests] temporarily disable node 4 and 5 tests
134501a 
See import-js#2053
ljharb added a commit to ljharb/eslint-plugin-import that referenced this issue May 13, 2021
@ljharb
[Tests] temporarily disable node 4 and 5 tests
650fbef 
See import-js#2053
ljharb added a commit to ljharb/eslint-plugin-import that referenced this issue May 13, 2021
@ljharb
[Tests] temporarily disable node 4 and 5 tests
9539a5d 
See import-js#2053
@soryy708
Copy link
Collaborator

Node 4 is already enabled:

Node 5 is also already enabled:

Therefore looks to me like this was already completed

@ljharb
Copy link
Member Author

ljharb commented Jan 23, 2025

node 4 is enabled on windows, but the other things you listed are specific exclude combinations - the tests still aren't running.

@ljharb ljharb reopened this Jan 23, 2025
@soryy708 soryy708 mentioned this issue Jan 23, 2025
Open
@MichaelDeBoey
Copy link

@ljharb I guess these tests will be obsolete once #3091 is merged?

@ljharb
Copy link
Member Author

ljharb commented Jan 23, 2025

@MichaelDeBoey yep

@ljharb ljharb linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-process
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: drop Node 4, 6, 8, 10, 12, 14 & 16 support MichaelDeBoey/eslint-plugin-import
3 participants
@ljharb @soryy708 @MichaelDeBoey