-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oidc-agent clients do not appear in My clients tab #652
Comments
There are more points of discussion to take into account:
|
I would say that the owner is the operator, even if the subject is of another user. In other words, the owner is the one with the RAT (assuming that we can get it again from oidc-agent during client registration). In fact, the operator doesn't even need to be part of the organization...
I would say the owner is the one who registers and has the RAT, unless the RAT is passed to someone else which can redeem (but I would rename it to "reclaim") the ownership. F. |
Is there an use-case where dynamic anonymous registration is useful on the production IAM instances? Applications that register new clients should first login. It seems to me a bit weird that anonymous can create client / database entry - what happens if some bad person decides to do millions of registration? Client ownership can be dangerous in some cases, e.g. if IAM Admin assign to the client some restricted scopes and owner can than add client_credential grant type to avoid scope policies that are applied only to the refresh token flow. |
All oidc-agent clients are dynamically and anonymously registered (for ATLAS it's 118 out of 175, for example). The subsequent consent requires authentication.
Denial of service. But there are easier ways to mount a denial of service attack.
It all depends on what a client owner can do. There is non such role at the moment (in practice). |
I guess this is just a side effect that |
Sure. Token usability is not great at the moment. |
At least in IAM 1.9.0 owner is still able to add May be this is not really issue if IAM administrators knows that they should never add restricted scope to the client owned by user or client where user have access to registration token. Basically, IAM administrators should know that restricted scopes can be safely added only to the clients they created and they did not set its owner to the user ... is this assumption about IAM admin knowledge safe or dangerous? |
Hi Petr, since client_credential flow is gaining more power (as you say it is not filtered by policies and so on) we are thinking about it as an authorization grant that excludes all other grants for the same client, i.e. there is no possibility to add more grants for the same client if client_credentials is one of them. I think this should solve also your use-case, isn't it? If we want to keep discussing this functionality I would open a separate issue. |
oidc-agent
registers new clients trough an unauthenticated request to the IAM registration endpoint. Because of this, a user who approved that client thinks that theoidc-agent
client should appear in the My clients left tab of the IAM dashboard.We should fix this assuming that the user who gave grant to the
oidc-agent
client is also a client owner. And we should find a way to select onlyoidc-agent
clients during this client linking, otherwise all clients that allow login with IAM would appear in the My clients tab of authenticated users.The text was updated successfully, but these errors were encountered: