Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: v4 or v5 #273

Open
mahnunchik opened this issue Mar 4, 2021 · 7 comments
Open

Question: v4 or v5 #273

mahnunchik opened this issue Mar 4, 2021 · 7 comments

Comments

@mahnunchik
Copy link

The questions are for education purpose:

@fanatid
Copy link
Collaborator

fanatid commented Mar 4, 2021

v5.0.0 introduced some renames, you can find full lines of changes in this PR: #219
I think npm shows v4 as latest because they define the latest version by date. v4.12.0 was published after v5.2.0.

@mahnunchik
Copy link
Author

I think it is better to clarify for end users, because there is inconsistency: before v4.12.0 and v5.2.0 latest was v5, now it is v4. So npm install bn.js installs different version.

@mahnunchik
Copy link
Author

Yep, I think it is good idea to clarify it in the readme there are two version of library (master branch for v5 and v4.x for v4) with slightly different method names.

@fanatid
Copy link
Collaborator

fanatid commented Mar 4, 2021

I fixed latest tag (thanks to npm support for npm dist-tag add <pkg>@<version> latest), now latest point to 5.2.0.

@fleksin
Copy link

fleksin commented Sep 5, 2022

is it safe to automatically replace 4.x with 5.x ?

@twoKilo
Copy link

twoKilo commented Sep 27, 2022

just share the same concerns, is that safe to migrate from v4 to v5? My webpack bundle has multiple bn.js, I'd like to add a resolution of v5 to solve the problem. however, some package depends on v4.

@ssbarbee
Copy link

ssbarbee commented Dec 3, 2022

same questions as @twoKilo. Adding resolution might shave few KBs, but given that there is no clear explanation on difference between v5 and v4 it might cause more harm than benefit. @fanatid can you share some insights? Is it safe to add resolution so that v4 resolve to v5, or there are breaking changes not documented in the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants