Skip to content
This repository has been archived by the owner on Apr 3, 2022. It is now read-only.

add a go.mod file #3

Open
mvdan opened this issue Dec 6, 2021 · 4 comments
Open

add a go.mod file #3

mvdan opened this issue Dec 6, 2021 · 4 comments

Comments

@mvdan
Copy link

mvdan commented Dec 6, 2021

I realise that this library is still usable without being a module directly, but I imagine there's no reason to avoid adding a go.mod file either?

One good reason to add a go.mod file is that one can use commands like go build, go list, and so on. Another is UX: it's not entirely clear that I'm meant to import this as inet.af/netstack rather than github.com/inetaf/netstack if I don't see a go.mod saying as much.

@mvdan
Copy link
Author

mvdan commented Dec 6, 2021

Huh, the README even mentions and links to a go.mod file in this repository, but it's a 404.

@mvdan
Copy link
Author

mvdan commented Dec 6, 2021

Seems particularly necessary too, given that this library requires three other modules.

Looks like the file was added/modified in 0407d1a. It hasn't been deleted since, that I can see in the git log. Perhaps one of the git merges somehow dropped the old master history, and entirely replaced it with an upstream history lacking the go.mod file?

@bradfitz
Copy link
Contributor

bradfitz commented Dec 6, 2021

Whoops. I have a huge complicated abomination of a shell script with gnarly git commands to build this repo and I guess I lost a step in there somewhere.

@polynomialspace
Copy link

Looks like it was lost in 1c1bcf4, which just happened to be a few days after google/gvisor@d350c95 bumped go.mod to 1.17.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants