Move commandListener callbacks outside of render cycle #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamonholmgren
commented
Mar 1, 2025
| @@ -135,12 +135,15 @@ export function reducer(state: State, action: Action) { | |||
| return | |||
| } | |||
|
|
|||
| draftState.commandListeners.forEach((cl) => cl(action.payload)) | |||
There was a problem hiding this comment.
This is now on line 217 below.
frankcalise
approved these changes
Mar 1, 2025
|
@joshuayoes How do I release using the new system? |
|
@jamonholmgren we built this cool thing called IR docs https://docs.infinite.red/reactotron/contributing/releasing/ |
|
@frankcalise I actually read that, believe it or not ... but I don't know if there's a format for the commit messages to get picked up by the release notes / changelog. |
|
fair, judging by the merged PRs it looks to be the same as Ignite |
|
@jamonholmgren you make a change in the workspace you want to release and the use semantic version keywords in your squash commit title: feat, fix, or chore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commandListener callbacks were running during the
dispatch, which breaks React since it's during a render cycle.This moves it outside of the
dispatchcall.Fixes #1542.
yarn build-and-test:localpassesAlso I'm going to kill this Redux-ish state management system and move to something closer to MobX or Legend State. It's awful to work with.