Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Authorization salt from the codebase #20

Open
marsbergen opened this issue Jul 30, 2024 · 0 comments
Open

Remove Authorization salt from the codebase #20

marsbergen opened this issue Jul 30, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@marsbergen
Copy link
Contributor

Context

We introduced a security risk in our MVP by putting the Authorization salt directly in the code. It was a poor decision, but made for a quick demo of the token generation. Now we need to move it to the configuration so it can be passed in by our build pipelines via environment variables.

Technical Requirements

  • Move the salt in the Authorization class to the conf.json.
@marsbergen marsbergen added bug Something isn't working good first issue Good for newcomers labels Jul 30, 2024
@infowijs infowijs locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant