code reivew remarks

Author: adamsmo

src/main/resources/application.conf

@@ -92,11 +92,11 @@ grothendieck {
 
     peer {
       # Retry delay for failed attempt at connecting to a peer
-      connect-retry-delay = 5 seconds
+      connect-retry-delay = 1 minute
 
       # Maximum number of reconnect attempts after the connection has been initiated.
       # After that, the connection will be dropped until its initiated again (eg. by peer discovery)
-      connect-max-retries = 5
+      connect-max-retries = 2
 
       disconnect-poison-pill-timeout = 5 seconds
 

src/main/scala/io/iohk/ethereum/blockchain/sync/FastSync.scala

@@ -234,10 +234,13 @@ trait FastSync {
         s"""|Block: ${appStateStorage.getBestBlockNumber()}/${initialSyncState.targetBlock.number}.
             |Peers waiting_for_response/connected: ${assignedHandlers.size}/${handshakedPeers.size} (${blacklistedPeers.size} blacklisted).
             |State: $downloadedNodesCount/$totalNodesCount nodes.
-            |Details: connected(${assignedHandlers.values.map(formatPeer).toSeq.sorted})/
-            |handshaked(${handshakedPeers.keys.map(formatPeer).toSeq.sorted})
-            | blacklisted(${blacklistedPeers.map { case (id, _) => id }})
             |""".stripMargin.replace("\n", " "))
+      log.debug(
+        s"""|Connection status: connected(${assignedHandlers.values.map(formatPeer).toSeq.sorted.mkString(", ")})/
+            |handshaked(${handshakedPeers.keys.map(formatPeer).toSeq.sorted.mkString(", ")})
+            | blacklisted(${blacklistedPeers.map { case (id, _) => id.value }.mkString(", ")})
+            |""".stripMargin.replace("\n", " ")
+      )
     }
 
     private def cleanupRequestedMaps(handler: ActorRef): Unit = {