Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signer does not handle properly signature signed entity timeout #2229

Closed
3 tasks done
jpraynaud opened this issue Jan 17, 2025 · 0 comments · Fixed by #2232
Closed
3 tasks done

Signer does not handle properly signature signed entity timeout #2229

jpraynaud opened this issue Jan 17, 2025 · 0 comments · Fixed by #2232
Assignees
Labels
bug ⚠️ Something isn't working

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jan 17, 2025

Why

The signer can get stuck when an open message has expired on the aggregator (as described in https://discord.com/channels/826816523368005654/1014019542504185876/1328667162524516384 and https://discord.com/channels/826816523368005654/1014019542504185876/1328523813352116327):

  • it tries to sign over and over again the same signed entity type (here the Cardano stake distribution)
  • each time the aggregator answers a 500 error stating that the message has expired
  • this error prevents the signer to record the signature (which would allow to sign the next signed entity type at the following cycle)

What

Have the signer consider a message signed even if the aggregator returns an error because of an expired open message when the signature is submitted.

How

  • Return a GONE HTTP code when the CertifierServiceError returned is Expired
  • In the signer, enhance the handling of the GONE HTTP code in register_signatures function to use the error message returned by the aggregator
  • In the signer, remove the CONFLICT handling of the register_signatures signature function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ Something isn't working
Projects
None yet
2 participants