config: add MMIO layout #339
Open
+154
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaojiaqi7
force-pushed
the
0211/add_mmio_layout_config
branch
2 times, most recently
from
d72b805 to
e82de11
Compare
|
Can we add additional check for overlap between MMIO and physical RAM? Just panic!() if this happens. |
gaojiaqi7
force-pushed
the
0211/add_mmio_layout_config
branch
2 times, most recently
from
dadcedd to
f0b6e32
Compare
jyao1
reviewed
Feb 13, 2025
| } | ||
|
|
||
| // Ensure that the MMIO64 range does not overlap with the MMIO32 space. | ||
| if config.mmio64_start > config.mmio32_start as u64 |
There was a problem hiding this comment.
Can we just simply make sure mmio64 > 4GB?
The rule is:
- mmio32 < 4GB
- mmio64 > 4GB
- PCIe should not overlap with them
jyao1
reviewed
Feb 13, 2025
src/devices/pci/src/mmio.rs
Outdated
| u32::MAX as u64 + 1 | ||
| }; | ||
| if (end_of_ram > MMIO32_START as u64 && end_of_ram < (MMIO32_START + MMIO32_SIZE) as u64) | ||
| || end_of_ram > MMIO64_START |
There was a problem hiding this comment.
we need 2 end_of_ram value.
- top of low usable memory (< 4GB memory), not overlap with mmio32 range.
- top of up usable memory (> 4GB memory), not overlap with mmio64 range.
The new configuration file contains the address and size of MMIO space and PCIE config space. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0211/add_mmio_layout_config
branch
from
f0b6e32 to
0b1da35
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| pub const MMIO32_START: u32 = 0xC000_0000; | ||
| pub const MMIO32_SIZE: u32 = 0x2000_0000; | ||
| use crate::{PciError, Result, MMIO32_SIZE, MMIO32_START, MMIO64_START}; |
Check warning
Code scanning / clippy
unused import: MMIO32_SIZE Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new configuration file contains the address and size of MMIO space and PCIE config space.
Closes #115