-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: override the indices entrypoint #84
Comments
@nharraud which default mappings would you like to remove? |
@jirikuncar In B2Share case, all of them. We only use marc21 for exports, not internally. Especially the "deposits" mapping which prevent us from using the same name. |
Or at least we don't use marc21 internally for now. If we use the authority module later it will make sense to use it then. For other records we will keep our own format. |
Can you remove them manually from invenio-search/invenio_search/ext.py Lines 50 to 51 in e9a23e9
Posible solutions for discussion:
|
Another solution I am using in the mean time is to index directly in the index and not the alias. Then I avoid the elasticsearch error complaining about multiple indices per alias. The search will still work the same way. The blacklist issue is that new indices might still pop up when a module is updated. |
|
Problem:
As soon as one uses Invenio-search all indices registered in the entrypoint will be added to elasticsearch. The problem is that some services don't want the ones provided by default. The only way to override the entrypoint name is by not using invenio-base as it is given directly to the extension.
Who has this problem:
Suggested solution:
Move the entrypoint name to the configuration.
Timeline:
This is not urgent but might be problematic if two mappings conflict (one from invenio and another from the overlay) after an upgrade.
The text was updated successfully, but these errors were encountered: