fix: Flaky tests when run in GitHub Actions Workflow #724
Labels
Comments
|
The windows tests fail too, they just report as green... |
7 tasks
7 tasks
spydon
pushed a commit
that referenced
this issue
Jun 26, 2024
## Description Hey everyone! I initially attempted to resolve this issue by following the approach mentioned in [this issue](dart-lang/pub#3998) by setting the environment variable `PUB_SUMMARY_ONLY=1` in the workflow. However, this did not work as expected. Then, I decided to solve it by updating the `ignoringDependencyMessages` method in the matcher file, and this approach seems to be working fine. **Changes:** - Remove unnecessary TODO comment in the workflow file - Update test command in workflow to remove unnecessary `|| true` - Update dependency messages matcher in `matchers.dart` test file Issue: #724 ## Type of Change - [ ] ✨ `feat` -- New feature (non-breaking change which adds functionality) - [x] 🛠️ `fix` -- Bug fix (non-breaking change which fixes an issue) - [ ] ❌ `!` -- Breaking change (fix or feature that would cause existing functionality to change) - [ ] 🧹 `refactor` -- Code refactor - [x] ✅ `ci` -- Build configuration change - [ ] 📝 `docs` -- Documentation - [ ] 🗑️ `chore` -- Chore
|
The macOS tests are failing pretty much every run now too: |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Version
main
Description
We currently have some flaky tests (they pass sometimes, and sometimes not) especially on MacOS, but also Linux.
For some reason the windows tests seem to always pass.
Steps to reproduce
Run the test suite as a GitHub Actions Workflow:
https://github.com/invertase/melos/actions/runs/9396915772/attempts/2
Expected behavior
The test suite should pass.
Screenshots
No response
Additional context and comments
No response
The text was updated successfully, but these errors were encountered: