Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Info.plist generated by disableAppTransportSecurity #5090

Open
javialon26 opened this issue May 17, 2024 · 0 comments
Open

Wrong Info.plist generated by disableAppTransportSecurity #5090

javialon26 opened this issue May 17, 2024 · 0 comments
Labels

Comments

@javialon26
Copy link

javialon26 commented May 17, 2024

Description:
The Info.plist generated by the command ionic capacitor run ios -l is incorrect and prevents Xcode from building the app if the key NSAppTransportSecurity is already defined.
The issue started after updating to Xcode 15.2. Previous versions like 14 work as expected.

Steps to Reproduce:

  1. Create an ionic app with iOS support
  2. Add the following configurations to the Info.plist file:
<key>NSAppTransportSecurity</key>
	<dict>
		<key>NSExceptionDomains</key>
		<dict>
			<key>facebook.com</key>
			<dict>
				<key>NSIncludesSubdomains</key>
				<true/>
				<key>NSThirdPartyExceptionRequiresForwardSecrecy</key>
				<false/>
			</dict>
		</dict>
	</dict>
  1. Run the app with the command ionic capacitor run ios -l.

Output:
The Xcode build fails with the following error:

[capacitor]         error: unable to read property list from file: /Volumes/Projects/xxx/ios/App/App/Info.plist: The operation couldn’t be completed. (XCBUtil.PropertyListConversionError error 2.) (in target 'App' from project 'App')

My ionic info:

Ionic:

   Ionic CLI       : 6.20.9
   Ionic Framework : @ionic/react 6.7.5

Capacitor:

   Capacitor CLI      : 6.0.0
   @capacitor/android : 6.0.0
   @capacitor/core    : 6.0.0
   @capacitor/ios     : 6.0.0

Utility:

   cordova-res : not installed globally
   native-run  : 2.0.1

System:

   NodeJS : v20.13.1 (/Users/xxxx/.nvm/versions/node/v20.13.1/bin/node)
   npm    : 10.5.2
   OS     : macOS Unknown

Other Information:
The problem is in the disableAppTransportSecurity method in https://github.com/ionic-team/ionic-cli/blob/%40ionic/cli%407.2.0/packages/%40ionic/cli/src/lib/integrations/capacitor/ios.ts

Line 45 adds the true value without adding NSAllowsArbitraryLoads key.

As a workaround I added the default values to the Info.plist in the NSAppTransportSecurity dict:

    <key>NSAllowsArbitraryLoads</key>
    <false/>
@ionitron-bot ionitron-bot bot added the triage label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant