Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

$cordovaLaunchNavigator doesn't work #1439

Open
yjukaku opened this issue Aug 16, 2017 · 0 comments
Open

$cordovaLaunchNavigator doesn't work #1439

yjukaku opened this issue Aug 16, 2017 · 0 comments

Comments

@yjukaku
Copy link

yjukaku commented Aug 16, 2017

Thank you for your excellent work on ngCordova!

There is a major bug in the latest version(s) of ngCordova's wrapper of the launchnavigator plugin. Looking at line https://github.com/ionic-team/ng-cordova/blob/master/src/plugins/launchNavigator.js#L12 of the plugin wrapper, we can see:

        launchnavigator.navigate(
          destination,
          start,
          function (){
            q.resolve();
          },
          function (error){
            q.reject(error);
          },
	options);

This is not a valid set of parameters to the launchnavigator's navigate function, which you can see below (https://github.com/dpa99c/phonegap-launch-navigator#navigate) :

launchnavigator.navigate(destination, options);
OR
launchnavigator.navigate(destination, successCallback, errorCallback, options);

The short of it is that the navigate function doesn't take start as a parameter, but rather expects it to be part of the options parameter. This causes an error and no navigation being launched when the app is used.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant