Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The non-zstd (default) artifacts mode is causing deps rebuild #323

Closed
dpc opened this issue May 12, 2023 · 4 comments
Closed

The non-zstd (default) artifacts mode is causing deps rebuild #323

dpc opened this issue May 12, 2023 · 4 comments

Comments

@dpc
Copy link
Contributor

dpc commented May 12, 2023

I was trying #322 and noticed that in my build, at the end of buildWorkspaceDepsOnly step, nix is doing bunch of shrinking ... and afterwards the buildWorkspace is rebuilding all the dependencies from scratch.

Edit: Just checked and it seems that v0.12.1 behaves correctly. It also does the shrinking but when buildWorkspace starts it only builds local crates as expected.

BTW. It still seems to me that nix should not mess with these files under ./target... seems sus, and takes extra time.

> cargo --version
cargo 1.67.0 (8ecd4f20a 2023-01-10)
> rustc --version
rustc 1.67.0 (fc594f156 2023-01-24)
@dpc dpc changed the title The non-zstd (default) artifacts mode is causing deps The non-zstd (default) artifacts mode is causing deps rebuild May 12, 2023
@ipetkov
Copy link
Owner

ipetkov commented May 15, 2023

Edit: Just checked and it seems that v0.12.1 behaves correctly. It also does the shrinking but when buildWorkspace starts it only builds local crates as expected.

@dpc just to be clear, are you only seeing this behavior on #322 but not in v0.12.1? If so we can move the convo there, otherwise we can investigate this further

@dpc
Copy link
Contributor Author

dpc commented May 15, 2023

I see it everywhere when I don't use zstd, and given that everything is fine with v0.12.1, it might not be actually any problem. (Though it looks weird and seems to waste time).

@ipetkov
Copy link
Owner

ipetkov commented May 16, 2023

That might be from mkDerivation's various post-installation hooks (which seek to strip out debug info and compress files, etc.) which might be crawling all the symlinked cargo artifacts. You could try disabling those and see if that helps!

@dpc
Copy link
Contributor Author

dpc commented May 18, 2023

I'm unable to reproduce. No idea what did I do wrong/different.

@dpc dpc closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants