Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused parameter error_template #225

Closed
salvatorelaiso opened this issue Jan 12, 2024 · 1 comment · Fixed by #380
Closed

Unused parameter error_template #225

salvatorelaiso opened this issue Jan 12, 2024 · 1 comment · Fixed by #380
Assignees
Milestone

Comments

@salvatorelaiso
Copy link
Collaborator

The parameter error_template seems like is unused.

This parameter, which is found in example/satosa/pyeudiw_backend.yaml is referenced only in the following code (not considering test files):

# TODO - for rendering custom errors
# self.error_page = self.loader.get_template(
# config["error_template"]
# )

See also #154.

Outside the mentioned code (which is commented-out) there is no other use of this parameter.

@peppelinux
Copy link
Member

please clean up the code and the html template about this error template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants