Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more group_by functions #523

Open
6 tasks
dreadatour opened this issue Oct 20, 2024 · 3 comments
Open
6 tasks

Implement more group_by functions #523

dreadatour opened this issue Oct 20, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dreadatour
Copy link
Contributor

dreadatour commented Oct 20, 2024

This is a follow-up issue for the #228.

We still have implement the following group_by functions:

  • first
  • last
  • std
  • var
  • min - for not int/float should return None is None in a list, otherwise - any value(like max([None, None, "Cat", "Dog", None]) --> None)
  • max - for not int/float should return any value but None (like max([None, None, "Cat", "Dog", None]) --> "Cat")
@dreadatour dreadatour added the enhancement New feature or request label Oct 20, 2024
@dmpetrov
Copy link
Member

We need to update the code to use new func module only.

Yes, it should be imported from top level from datachain.func import min, concat

PS: it looks like there are 3 issues in this one :)

@dreadatour
Copy link
Contributor Author

PS: it looks like there are 3 issues in this one :)

🤔 Indeed. Let me split it.

@dreadatour dreadatour changed the title Implement more group_by and window functions Implement more group_by functions Oct 21, 2024
@dreadatour
Copy link
Contributor Author

PS: it looks like there are 3 issues in this one :)

🤔 Indeed. Let me split it.

#524 + #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants